Fix deployment scripts#68
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates deployment/testing utilities and project configuration to support newer Polygon ID / iden3 packages and “unified address” deployments across networks.
Changes:
- Refactors request packing / request-id generation flows to use
@0xpolygonid/js-sdkhelpers andethersABI encoding. - Updates Hardhat network + env configuration and bumps key iden3/Polygon ID dependency versions.
- Refreshes scripts/README to use unified contract addresses and newer request-setting patterns (
setRequests).
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| test/utils/utils.ts | Removes local query-hash / verifier-id helpers; adds getChainId() using Hardhat provider. |
| test/utils/pack-utils.ts | Replaces web3 ABI encoding with ethers AbiCoder for packing validator params/proofs. |
| scripts/upgradeV3Validator.ts | Updates example validator address and removes unused imports. |
| scripts/upgradeSigValidator.ts | Updates example validator address and removes unused imports. |
| scripts/upgradeMTPValidator.ts | Updates example validator address and removes unused imports. |
| scripts/setRequests-v3validator.ts | Moves to unified addresses + setRequests, uses SDK helpers for request id/hash. |
| scripts/setRequests-v2validator.ts | Moves to unified addresses + setRequests, uses SDK helpers for request id/hash. |
| scripts/deployV3Validator.ts | Updates wrapper name and deployProxy initializer args/output. |
| scripts/deploySigV2Validator.ts | Updates wrapper name and deployProxy initializer args/output. |
| scripts/deployMTPV2Validator.ts | Updates wrapper name and deployProxy initializer args/output. |
| scripts/deployIdentityExample.ts | Updates default state address to unified address. |
| scripts/deployERC20SelectiveDisclosure.ts | Adds verifier lib deployment/linking and setRequests flow with computed requestId. |
| scripts/deployERC20LinkedUniversalVerifier.ts | Fixes constructor args passed to deployContract. |
| scripts/deployERC20.ts | Reworks deploy + request creation to support multiple circuit ids and setRequests. |
| scripts/deployBalanceCredentialIssuer.ts | Updates default state address to unified address. |
| package.json | Bumps iden3/PolygonID deps; removes Mumbai scripts. |
| hardhat.config.ts | Renames/adds networks, updates Etherscan config, disables contract sizer on compile. |
| README.md | Replaces per-network address tables with unified-address docs and notes. |
| .env.sample | Switches to a single PRIVATE_KEY plus per-network RPC URLs and Etherscan key. |
Comments suppressed due to low confidence (3)
README.md:22
- Spelling: “which where deployed” should be “which were deployed”.
README.md:16 - Markdown formatting:
**Universal Verifier V2****has an extra**which breaks the bolding and table alignment. Remove the extra asterisks so the label renders correctly.
README.md:26 - Grammar: “There are a few libraries, which does not tend to evolve much …” is ungrammatical; it should be “which do not tend …” (or rephrase the sentence).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
OBrezhniev
reviewed
Apr 21, 2026
vmidyllic
approved these changes
Jun 16, 2026
daveroga
added a commit
that referenced
this pull request
Jun 16, 2026
* update contracts and erc20.ts test * update erc20 test with stubs * fix contracts and tests with new verifiers * fix updates verifier * remove json proofs for testing * update iden3 contracts package * get userID in afterproofsubmit * update userID example * Fix deployment scripts (#68) * fix deployERC20 script * comment hardhat fork in hardhat config * update readme and fix other deployment scripts * upgrade deployment scripts * fix set and upgrade scripts * verify contracts after deployment * fix typos * fix package json and readme scripts * fix linea * remove unnecessary scripts and other updates * example allowed issuers --------- Co-authored-by: GopherDID <74898029+vmidyllic@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.